[Forwardport] Module Catalog: fix issue with custom option price conversion for different base currency on website level#18257
Merged
magento-engcom-team merged 1 commit intomagento:2.3-developfrom Oct 12, 2018
Conversation
…ferent base currency on website level
baf7a34 to
4719a6e
Compare
Contributor
|
Hi @oleksii-lisovyi. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
sidolov
approved these changes
Sep 26, 2018
Contributor
|
Hi @sidolov, thank you for the review. |
magento-engcom-team
pushed a commit
that referenced
this pull request
Oct 12, 2018
…on price conversion for different base currency on website level #18257
Contributor
|
Hi @oleksii-lisovyi. Thank you for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#18225
Description
Issue is connected to the custom option price conversion based on base currency configured on default level, but not on website level (Magento allows to configure different base currency on website level according to documentation).
It's reproduced on the following Magento setup with multi-currency configuration:
Fixed Issues (if relevant)
No related issues found.
Manual testing scenarios
Steps to reproduce
Expected result
Custom option value price is not changed, because no actual changes were done.
Actual result
Custom option value price is updated according to USD/CAD currency rate.
Contribution checklist